Infra for regeneration of third-party-notices file #60091
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
src/tasks/installer.tasks/StaticFileRegeneration/RegenerateThirdPartyNotices.cs
Show resolved
Hide resolved
src/tasks/installer.tasks/StaticFileRegeneration/RegenerateThirdPartyNotices.cs
Outdated
Show resolved
Hide resolved
src/tasks/installer.tasks/StaticFileRegeneration/TpnDocument.cs
Outdated
Show resolved
Hide resolved
|
@dagood @akoeplinger is this now good for merging? I'm waiting on one approving review. |
| <TpnRepo Include="dotnet/wpf" /> | ||
|
|
||
| <!-- | ||
| Additional repos that should be included but don't have any third-party-notices files: |
There was a problem hiding this comment.
Do we have an issue which tracks adding these repos?
dotnet/emsdk would be another one.
There was a problem hiding this comment.
Thanks - I've added this repo and created the tracking issue: #61466
|
@NikolaMilosavljevic is this ok to merge now? |
|
@NikolaMilosavljevic is this OK to merge? or else we should close it. |
|
@danmoseley I'll need to verify that this still works fine with potential infra changes that happened in the meantime. |
|
Verified that infra is still compatible with original changes. TPNs can be regenerated with a simple command: |
|
Thanks @NikolaMilosavljevic ! |
* Infra for regeneration of third-party-notices file * Update eng/regenerate-third-party-notices.proj Co-authored-by: Davis Goodin <dagood@users.noreply.github.com> * Addressing PR comments * Updated copyright in all .cs files * Update dotnet/liner repo name * Add dotnet/emsdk to the list Co-authored-by: Davis Goodin <dagood@users.noreply.github.com>
ghost
locked as resolved and limited conversation to collaborators
This is based on infra originally implemented by @dagood dagood/core-setup@bac3b0d...100d6dc
It regenerates TPN file under src/installer/pkg, with content from dotnet/runtime and other repos. We used the same infra for .NET 5 release, but it was never merged into runtime repo.