Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some repos do not contribute to third-party-notices file #61466

Closed
6 of 7 tasks
NikolaMilosavljevic opened this issue Nov 11, 2021 · 10 comments
Closed
6 of 7 tasks

Some repos do not contribute to third-party-notices file #61466

NikolaMilosavljevic opened this issue Nov 11, 2021 · 10 comments

Comments

@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Nov 11, 2021

Here's a list of repos that should contribute to the shipping third-party-notices file, but that don't have their TPN file established in their repos.

We need to work with each repo owner to establish and maintain their TPN files. Once that is changed, our TPN generation infra (in PR: #60091) should be updated.

Additional repos that should be included but don't have any third-party-notices files:

  • dotnet/efcore - confirmed, no 3p code
  • dotnet/emsdk - content likely needed
  • dotnet/icu - content likely needed Add TPN for ICU icu#200
  • dotnet/extensions - under the Runtime and ASPNet repos and covered by those TPNs
  • dotnet/sdk - possibly covered by dotnet/installer TPN
  • dotnet/windowsdesktop - confirmed, no 3p src in WinForms or WPF shipping assets
  • dotnet/linker - will be resolved by Add license header to files that have no header linker#2469
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 11, 2021
@NikolaMilosavljevic NikolaMilosavljevic removed the untriaged New issue has not been triaged by the area owner label Nov 17, 2021
@NikolaMilosavljevic
Copy link
Member Author

[Triage] @leecow is this something you were tracking and can be enabled early in 7.0 so we have all contributing repos onboarded on time?

@leecow
Copy link
Member

leecow commented Nov 17, 2021

Yes, I can track and work with the missing repos.

@danmoseley
Copy link
Member

@NikolaMilosavljevic did you get a chance to reach out?

@NikolaMilosavljevic
Copy link
Member Author

@NikolaMilosavljevic did you get a chance to reach out?

@leecow was going to work with missing repos. @leecow were there any updates, should we have an issue for each repo to create TPN file, so we can harvest it and include relevant notices in the shipping file?

@leecow
Copy link
Member

leecow commented Mar 23, 2022

Sorry, fell off the plate. I like the idea of individual issues which I can open in the repos listed above. Will also communicate with owners internally to give them a heads up.

@NikolaMilosavljevic - To make sure I understand the need - do the repos need to host a TPN doc like this, or something else?

@RussKie
Copy link
Member

RussKie commented Mar 28, 2022

Windows Forms do not use any 3rd party dependencies (i.e., non Microsoft) in the production code (i.e., the code we ship in Windows Desktop). Standing by for the WPF sign off from @singhashish-wpf to complete the Windows Desktop story.

steveisok pushed a commit to steveisok/icu that referenced this issue Mar 30, 2022
steveisok added a commit to dotnet/icu that referenced this issue Apr 8, 2022
@NikolaMilosavljevic NikolaMilosavljevic added this to the 7.0.0 milestone Aug 17, 2022
@NikolaMilosavljevic
Copy link
Member Author

@leecow is there any pending work for the last remaining repo dotnet/emsdk?

We need to update main third-party-notices file, which will harvest TPNs from all dependent repos - #74605

@NikolaMilosavljevic
Copy link
Member Author

Removing 'blocking-release' label - we are updating TPN notices for 7.0 with #74760

@leecow
Copy link
Member

leecow commented Aug 29, 2022

@lewing - anything in emsdk that needs to be covered by a third-party license notice?

@NikolaMilosavljevic
Copy link
Member Author

Moving to 8.0 - we've updated TPN file for 7.0 release with: #74760

@NikolaMilosavljevic NikolaMilosavljevic modified the milestones: 7.0.0, 8.0.0 Aug 31, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

No branches or pull requests

4 participants