-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dispose rule and handle it in solution (production part) #9983
Add dispose rule and handle it in solution (production part) #9983
Conversation
src/Build.OM.UnitTests/Construction/ProjectRootElement_Tests.cs
Outdated
Show resolved
Hide resolved
src/Build/Logging/BinaryLogger/Postprocessing/StreamExtensions.cs
Outdated
Show resolved
Hide resolved
fd0332a
to
aa28c4f
Compare
aa28c4f
to
6b56301
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have partially reviewed the PR, leaving comments inline.
src/Build.OM.UnitTests/Microsoft.Build.Engine.OM.UnitTests.csproj
Outdated
Show resolved
Hide resolved
…github.com/YuliiaKovalova/msbuild into dev/ykovalova/enable_disposable_rule_check
8783283
to
6ef1733
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving some more inline comments (28/50 files reviewed).
src/Build/Logging/BinaryLogger/Postprocessing/StreamExtensions.cs
Outdated
Show resolved
Hide resolved
src/MSBuild.UnitTests/Microsoft.Build.CommandLine.UnitTests.csproj
Outdated
Show resolved
Hide resolved
96b0b7c
to
c8fee7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving a few more comments inline.
src/Build.OM.UnitTests/Microsoft.Build.Engine.OM.UnitTests.csproj
Outdated
Show resolved
Hide resolved
… available in the ClickOnce's bootstrapper packages folder (#10093) #9983 introduced a regression in ClickOnce's bootstrapper packages builder code by disposing an XmlReader object while it's still in use. Fix the bootstrapper builder code that validates against a schema file to use the XmlReaderSettings instead of the deprecated XmlValidatingReader class.
Context
The absence of this rule cause a memory leak during execution.
Changes Made
Enable CA2000 rule for production code and temporary make exception for test projects.