[ClickOnce] Fix BootstrapperBuilder code to correctly return the list of products available in the packages folder #10093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… available in the ClickOnce's bootstrapper packages folder
rainersigwald
approved these changes
Apr 30, 2024
John-Hart
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#2046752
Context
#9983 introduced a regression in ClickOnce's bootstrapper packages builder code by disposing an XmlReader object while it's still in use.
Changes Made
Fix the bootstrapper builder code that validates package/product XML against a schema file to use the XmlReaderSettings instead of the deprecated XmlValidatingReader class.
Testing
Updated code has been verified against valid and invalid schema file. In addition, the ClickOnce publish with bootstrapper products included has been verified.
Notes