Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable attribute usage in F# 9.0 #17763

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

KevinRansom
Copy link
Member

EnforceAttributeTargets was reset back to preview over the weekend.

The bug was fixed but the fix didn't re-enable the feature as part of F# 9.0

This makes it part of 9.0 so that when 9.1 ships the feature will be active as part of 9.0

/cc @vzarytovskii

@KevinRansom KevinRansom requested a review from a team as a code owner September 18, 2024 05:41
Copy link
Contributor

github-actions bot commented Sep 18, 2024

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@KevinRansom KevinRansom added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Sep 18, 2024
@vzarytovskii
Copy link
Member

vzarytovskii commented Sep 18, 2024

I made a pr already - #17752 will close mine

@vzarytovskii vzarytovskii enabled auto-merge (squash) September 18, 2024 10:53
@vzarytovskii vzarytovskii merged commit 767b5ec into dotnet:main Sep 18, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants