Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Move attribute enforcement from v9 to preview" #17752

Closed
wants to merge 5 commits into from
Closed

Revert "Move attribute enforcement from v9 to preview" #17752

wants to merge 5 commits into from

Conversation

vzarytovskii
Copy link
Member

Reverts #17739, since the fix is in.
@T-Gro @KevinRansom should this go to lang version 9.1, since 9 is frozen for release?

@vzarytovskii vzarytovskii requested a review from a team as a code owner September 16, 2024 18:02
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro
Copy link
Member

T-Gro commented Sep 17, 2024

The test regression should not be there, since Kevin's fixed address this.
Removed from the diff, now it should all pass with nothing but a langversion move.

@T-Gro T-Gro enabled auto-merge (squash) September 17, 2024 08:59
@edgarfgp edgarfgp added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Sep 17, 2024
@vzarytovskii vzarytovskii mentioned this pull request Sep 18, 2024
Merged
@edgarfgp
Copy link
Contributor

Just in case this PR gets merged instead of Kekin's . I think the tests should be using withLangVersion90 instead of withLangVersionPreview

auto-merge was automatically disabled September 18, 2024 10:53

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vzarytovskii @T-Gro @edgarfgp