[Xamarin.Android.Build.Tasks] remove Xamarin.Android.Legacy.targets and friends #7985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd friends
Taking a first pass at deleting MSBuild-related files that are not
used in .NET 8 and only existed to support "classic" Xamarin.Android.
Deleting:
* `Xamarin.Android.Legacy.targets`
* `Xamarin.Android.Aapt.targets`
* `Xamarin.Android.Wear.targets`
* Associated MSBuild task `.cs` files that are now unused
After these changes, I got the error from
`Xamarin.Android.NUnitLite.csproj`:
Xamarin.Android.Tooling.targets(52,31): error MSB4057: The target "_GetReferenceAssemblyPaths" does not exist in the project.
I removed this project from `Xamarin.Android.sln` for now, but it will
be a good target for removal in the future.
jonathanpeppers
requested review from
dellis1972,
grendello and
jonpryor
as code owners
dellis1972
approved these changes
Apr 24, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Apr 27, 2023
* main: [Xamarin.Android.Build.Tasks] remove Xamarin.Android.Legacy.targets and friends (dotnet#7985) Bump external/Java.Interop from `554d819` to `f0e3300` (dotnet#7982) [Xamarin.Android.Build.Tasks] stop redistributing `apksigner` (dotnet#7984)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a first pass at deleting MSBuild-related files that are not used in .NET 8 and only existed to support "classic" Xamarin.Android.
Deleting:
Xamarin.Android.Legacy.targetsXamarin.Android.Aapt.targetsXamarin.Android.Wear.targets.csfiles that are now unusedAfter these changes, I got the error from
Xamarin.Android.NUnitLite.csproj:I removed this project from
Xamarin.Android.slnfor now, but it will be a good target for removal in the future.