[Xamarin.Android.Build.Tasks] stop redistributing apksigner
#7984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #6307 This reverts c50df1c. In the past, we had to redistribute `apksigner.jar`, because it required JDK 11. This happened for build-tools 30.0.0 and was fixed in built-tools 30.0.3. At the time we were nowhere close able to use JDK 11, and so we built it ourselves for JDK 1.8 and redistributed it. However, .NET 6+ now *requires* JDK 11, because targets API-31 and higher. "Classic" Xamarin.Android requires JDK 11 if you are targeting API-31. We can remove `apksigner` from `main` going forward in .NET 8.
jonathanpeppers
requested review from
dellis1972,
grendello and
jonpryor
as code owners
dellis1972
approved these changes
Apr 24, 2023
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Apr 27, 2023
* main: [Xamarin.Android.Build.Tasks] remove Xamarin.Android.Legacy.targets and friends (dotnet#7985) Bump external/Java.Interop from `554d819` to `f0e3300` (dotnet#7982) [Xamarin.Android.Build.Tasks] stop redistributing `apksigner` (dotnet#7984)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6307
This reverts c50df1c.
In the past, we had to redistribute
apksigner.jar, because it required JDK 11. This happened for build-tools 30.0.0 and was fixed in built-tools 30.0.3. At the time we were nowhere close able to use JDK 11, and so we built it ourselves for JDK 1.8 and redistributed it.However, .NET 6+ now requires JDK 11, because targets API-31 and higher. "Classic" Xamarin.Android requires JDK 11 if you are targeting API-31.
We can remove
apksignerfrommaingoing forward in .NET 8.