Commits on Feb 11, 2019

1. [tests] Fix msbuild response file usage …

   Commit dotnet@578e781ba added support
   for using the `msbuild.rsp` response file when running tests in order to work
   around issues with diacritic characters on the command line. The commit assumed
   that the response file will be picked up automatically if it's found in
   the *project root directory*, however this is not the case as the response file
   is [documented][0] to exist in the same directory as `msbuild.exe` and thus some
   tests (EmbededDSOs, CodeBehind) were failing to build since important properties
   required for them to work were only in the response file and not specified on
   the command line passed to `msbuild.exe`.
   
   We missed the issue because Jenkins gave us a false-positive green build for
   those changes where in reality the tests did [not run at all][1]
   
   This fix appends `@"/path/to/msbuild.rsp"` to the msbuild's command line.
   
   [0]: https://docs.microsoft.com/en-us/visualstudio/msbuild/msbuild-response-files?view=vs-2017
   [1]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/1505/testReport/EmbeddedDSOUnitTests/

   

   grendello committed Feb 11, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for dac27a4
   • Browse repository at this point

   Copy the full SHA

   dac27a4 View commit details

   Browse the repository at this point in the history