[tests] Fix msbuild response file usage #2723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
requested review from
dellis1972 and
jonathanpeppers
as code owners
dellis1972
approved these changes
Feb 11, 2019
|
why did the tests not run in the first place? We should investigate that. |
Indeed... |
jonathanpeppers
approved these changes
Feb 11, 2019
|
@grendello if we are passing the response file with the '@' it cannot be named |
Commit dotnet@578e781ba added support for using the `msbuild.rsp` response file when running tests in order to work around issues with diacritic characters on the command line. The commit assumed that the response file will be picked up automatically if it's found in the *project root directory*, however this is not the case as the response file is [documented][0] to exist in the same directory as `msbuild.exe` and thus some tests (EmbededDSOs, CodeBehind) were failing to build since important properties required for them to work were only in the response file and not specified on the command line passed to `msbuild.exe`. We missed the issue because Jenkins gave us a false-positive green build for those changes where in reality the tests did [not run at all][1] This fix appends `@"/path/to/msbuild.rsp"` to the msbuild's command line. [0]: https://docs.microsoft.com/en-us/visualstudio/msbuild/msbuild-response-files?view=vs-2017 [1]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/1505/testReport/EmbeddedDSOUnitTests/
grendello
force-pushed
the
msbuild-response-file-fix
branch
from
167689f
to
dac27a4
Compare
dellis1972
approved these changes
Feb 11, 2019
jonathanpeppers
approved these changes
Feb 11, 2019
|
build |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 578e781ba added support
for using the
msbuild.rspresponse file when running tests in order to workaround issues with diacritic characters on the command line. The commit assumed
that the response file will be picked up automatically if it's found in
the project root directory, however this is not the case as the response file
is documented to exist in the same directory as
msbuild.exeand thus sometests (EmbededDSOs, CodeBehind) were failing to build since important properties
required for them to work were only in the response file and not specified on
the command line passed to
msbuild.exe.We missed the issue because Jenkins gave us a false-positive green build for
those changes where in reality the tests did not run at all
This fix appends
@"/path/to/msbuild.rsp"to the msbuild's command line.