Revert SchemaTool change to check for foreign key support #7937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…K support" This reverts commit 3707c39.
lcobucci
approved these changes
Dec 16, 2019
|
@beberlei thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3707c39 fixed the symptom that
SqlitePlatform#supportsForeignKeyConstraints()returns false, even though we now have emulation in plcae that allows us to set this to true.This fixes regression #7930 introduced in 2.6.5 by #7841 and #7842
Explanation why fix is wrong: #7842 (comment)
Related PR on DBAL that fixes SQLite Foreign Key Handling: doctrine/dbal#3762