Merge pull request #7937 from doctrine/GH-7930-SqliteForeignKeys

Revert SchemaTool change to check for foreign key support
doctrine · Dec 16, 2019 · 5873242 · 5873242
2 parents c9e41d0 + cfd6fad
commit 5873242
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 65 deletions.
diff --git a/lib/Doctrine/ORM/Tools/SchemaTool.php b/lib/Doctrine/ORM/Tools/SchemaTool.php
@@ -709,11 +709,6 @@ private function gatherRelationJoinColumns(
         }
 
         $compositeName = $theJoinTable->getName().'.'.implode('', $localColumns);
-
-        if (! $this->platform->supportsForeignKeyConstraints()) {
-            return;
-        }
-
         if (isset($addedFks[$compositeName])
             && ($foreignTableName != $addedFks[$compositeName]['foreignTableName']
             || 0 < count(array_diff($foreignColumns, $addedFks[$compositeName]['foreignColumns'])))

diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2138Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/DDC2138Test.php
@@ -14,9 +14,6 @@ class DDC2138Test extends OrmFunctionalTestCase
     public function testForeignKeyOnSTIWithMultipleMapping()
     {
         $em = $this->_em;
-        if (! $em->getConnection()->getDatabasePlatform()->supportsForeignKeyConstraints()) {
-            $this->markTestSkipped('Platform does not support foreign keys.');
-        }
         $schemaTool = new SchemaTool($em);
 
         $classes = [

diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/GH7841Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/GH7841Test.php