Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change uptime alert comparison type #637

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

mikesmithgh
Copy link
Contributor

This PR is to support the work I am doing on digitalocean/doctl#1431 as part of #hacktoberfest.

For the validation of the uptime alert comparison field, I followed the same pattern as
monitoring.go#L106-L107 AlertPolicyComp

Please let me know what you think, Thanks!

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Thanks for the contribution @mikesmithgh!

@danaelhe danaelhe merged commit cec3a8b into digitalocean:main Oct 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants