Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add uptime alerts commands #1431

Merged
merged 6 commits into from
Oct 11, 2023
Merged

feat: add uptime alerts commands #1431

merged 6 commits into from
Oct 11, 2023

Conversation

mikesmithgh
Copy link
Contributor

@mikesmithgh mikesmithgh commented Oct 9, 2023 •
edited
Loading

PR for #1419 as part of #hacktoberfest

Checklist:

@mikesmithgh mikesmithgh mentioned this pull request Oct 9, 2023
Merged
@mikesmithgh
Copy link
Contributor Author

Hi @danaelhe this PR is ready for review. I am leaving it in draft until its dependent PR digitalocean/godo#637 is merged. After that is merged, I'll run the vendor command and update this PR.

It looks like I made a lot of changes because I ran make mocks to generate the mocks for uptime_alerts_test.go. A new version of gomock was released recently which changes the signature on all the mocks causing all those updates.

Please let me know what you think. Thanks!

@danaelhe
Copy link
Member

Hi @danaelhe this PR is ready for review. I am leaving it in draft until its dependent PR digitalocean/godo#637 is merged. After that is merged, I'll run the vendor command and update this PR.

It looks like I made a lot of changes because I ran make mocks to generate the mocks for uptime_alerts_test.go. A new version of gomock was released recently which changes the signature on all the mocks causing all those updates.

Please let me know what you think. Thanks!

Awesome! I'll cut a new release of godo as well and then review this PR. That's totally fine. Thank you for the update!

@mikesmithgh mikesmithgh marked this pull request as ready for review October 10, 2023 19:45
@mikesmithgh
Copy link
Contributor Author

Awesome! I'll cut a new release of godo as well and then review this PR. That's totally fine. Thank you for the update!

@danaelhe Thanks! I just merged the changes and it ready for review 🙂

danaelhe
danaelhe previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look fantastic! This is an extremely high valuable contribution- thank you so much! I just had a few nit-picks on the documentation but other than that it's ready to go 🚀

commands/uptime_alerts.go Outdated Show resolved Hide resolved
commands/uptime_alerts.go Outdated Show resolved Hide resolved
commands/uptime_alerts.go Outdated Show resolved Hide resolved
commands/uptime_alerts.go Outdated Show resolved Hide resolved
do/uptime_checks.go
// UptimeCheckState is a wrapper for godo.UptimeCheckState.
type UptimeCheckState struct {
*godo.UptimeCheckState
}

// UptimeChecksService is an interface for interacting with DigitalOcean's volume api.
// UptimeChecksService is an interface for interacting with DigitalOcean's uptime check api.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@mikesmithgh
Copy link
Contributor Author

Look fantastic! This is an extremely high valuable contribution- thank you so much! I just had a few nit-picks on the documentation but other than that it's ready to go 🚀

Thanks! I'll make the updates and let you know

@mikesmithgh
Copy link
Contributor Author

Look fantastic! This is an extremely high valuable contribution- thank you so much! I just had a few nit-picks on the documentation but other than that it's ready to go 🚀

Thanks! I'll make the updates and let you know

@danaelhe done!

danaelhe
danaelhe approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@danaelhe danaelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@danaelhe danaelhe merged commit 4c532f4 into digitalocean:main Oct 11, 2023
6 checks passed
@danaelhe danaelhe mentioned this pull request Oct 11, 2023
Closed
@mikesmithgh
Copy link
Contributor Author

🚀

🎉 awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danaelhe danaelhe danaelhe approved these changes

Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesmithgh @danaelhe