1214: Add pois to favorites

[seluianova]

Short description

Add the ability to save POIs as favorites on device

Proposed changes

• provide the functionality to add/remove a store to the favorites on the store detail page. save the information on the device
• display snack bar notification when a favorite has neen added/removed
• add a "favorite" BottomNavigationBar item
• add a favorite page that shows store favorites. style similar to the search list

Not included:

• mark the favorites with the favorites icon on the map

Maybe we could separate this part?
It's taking a while, because I'm not quite sure how to do it yet, if we don't make “Favorites” as a category.
Or I might need some help with that.

UPD. As discussed in the channel, we will implement that separately.

Side effects

Couldn't find any
Not tested on iOS

Resolved issues

Fixes: #1214

[ztefanie]

Looks good. Nice job 🚀

Tested on Android, works as expected 👍

[f1sh1918]

Good work 👍
There is one scenario we should catch.

1. User adds a store to favorites.
2. Later the store will be deleted because it doesn't participate anymore. (i removed from database to test)

Current behavior
The store is still in favorites. That ok but when i click on the store, the user is lost in this error screenshot. Retry doesn't help
Currently there is no proper error handling for this case. We should show in this case probably another error message and provide a way to go back

[seluianova]

There is one scenario we should catch

@f1sh1918 I think I would need your help to reproduce that.
I tried, but catched a different issue:
If favorites contain a store that is not in the database, AcceptingStoreByIdQuery returned it as Null, resulting in a casting error in _fetchPage().
I fixed that in the last commit, so the deleted store just won't show up in the favorites list without any fallbacks.

The store is still in favorites. That ok but when i click on the store, the user is lost in this error screenshot. Retry doesn't help
We should show in this case probably another error message and provide a way to go back

Currently I'm not quite sure how we can achieve this result, because in order to display a store item in the favorites list we need data about this store (name, description, category). But from where we could get it, if not from the database?
Perhaps I am missing something?

UPD: I also wonder, if you reproduce this scenario, do you get the same error if you open the removed store details on the “Search” page?

[seluianova]

UPD:

• all comments have been addressed;
• more data about favorite stores is now saved on the device (id, name, category id);
• if a favorite store has been deleted from the database, it is still displayed in favorites with a note that the store is no longer available and with the option to remove it from favorites;
• favorites are now stored in shared preferences rather than secure storage because they are not sensitive data and we basically don't need encryption for them (hopefully this change doesn't break on iOS, as I haven't tested it);
• I also started to add tests, but will continue within a separate task.

[f1sh1918]

Super nice pr 👍
Thx for adding tests :)
Tested on ios and works fine.
Just some small things
I think the icon size of the favorite icon should be increased a little bit.
I suggest iconSize:36 to be more prominent
Added screenshot with increased icon size