Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POIs to favorites #1214

Closed
f1sh1918 opened this issue Nov 15, 2023 · 4 comments · Fixed by #1461
Closed

Add POIs to favorites #1214

f1sh1918 opened this issue Nov 15, 2023 · 4 comments · Fixed by #1461

Comments

@f1sh1918
Copy link
Contributor

f1sh1918 commented Nov 15, 2023

As a user I want to add pois to favorites to find them easier on the map and store list

Acceptance Criteria:

  • a store can be added to favorites by clicking favorites cta button on the store detailpage (icon changes to filled)
  • the store will be marked with a favorite icon on the map instead of the category icon. The icon should have the same size as the other icons
  • In the ButtomNavigationBar a "Favorite" item should be added that navigates to the favorites page
  • the favorites page contains a list of acceptance stores the user added to favorites. It should behave like the of the search page. (click on the item -> store detail page)
  • a favorite store can be removed from favorites on the store detail page by clicking the favorites button (icon changes to outlined)
  • the favorites will be saved on the device, so they will maintain after the app was closed

Technical Tasks:

  • add a favorite icon to the mapstyle repository
  • provide the functionality to add/remove a store to the favorites on the store detail page. save the information on the device
  • mark the favorites with the favorites icon on the map
  • add a "favorite" BottomNavigationBar item
  • add a favorite page that shows store favorites. style similar to the search list

Design:

  • provide an material icon for the favorites
  • provide a cta/toggle for the detail page to add the store to favorites
  • provide a design that includes a new favorite item in the BottomActionBar
  • provide a design for the favorites pages that should be similar/equal to the SearchList

Some additional info:

To simplify this issue #750 should be done before

@f1sh1918 f1sh1918 added the blocked Task or user story can not be continued at the moment label Feb 7, 2024
@f1sh1918
Copy link
Contributor Author

@IsabellaTG i addressed some comments to you

@ztefanie ztefanie added discussion-needed We need to resolve the questions in the issue. and removed blocked Task or user story can not be continued at the moment labels Mar 2, 2024
@f1sh1918 f1sh1918 added ready and removed discussion-needed We need to resolve the questions in the issue. ui-ux labels Mar 11, 2024
@seluianova seluianova self-assigned this Apr 30, 2024
@seluianova
Copy link
Contributor

@dkehne could you please tell me if we need the ability to enable/disable this feature in the configuration per project?

@dkehne
Copy link

dkehne commented May 22, 2024

@seluianova no, we do not need to. it can be published for all projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants