Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inconsistent & wrong composer.focus() #4136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: inconsistent & wrong composer.focus() #4136

wants to merge 1 commit into from

Commits on Sep 18, 2024

  1. fix: inconsistent & wrong composer.focus() 

    - Erasing draft text and immediately focusing another element
  would return the focus to the composer after 500ms, when the draft
  gets deleted (`clearDraft` would get invoked from `saveDraft()`.
- Composer would not get re-focused when deleting / adding
  attachments or removing quotation if the draft text is not empty.

`.focus()` inside of `clearDraft()` was introduced in
199ea23, most likely to re-focus the
input after sending a message. We now have separate code for this,
see `composerSendMessage`.

This change likely needs some more testing.
    @WofWca
    WofWca committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d708835 View commit details
    Browse the repository at this point in the history