fix: inconsistent & wrong composer.focus()
#4136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WofWca
force-pushed
the
wofwca/fix-composer-focus
branch
from
972e206
to
1cf38c8
Compare
- Erasing draft text and immediately focusing another element would return the focus to the composer after 500ms, when the draft gets deleted (`clearDraft` would get invoked from `saveDraft()`. - Composer would not get re-focused when deleting / adding attachments or removing quotation if the draft text is not empty. `.focus()` inside of `clearDraft()` was introduced in 199ea23, most likely to re-focus the input after sending a message. We now have separate code for this, see `composerSendMessage`. This change likely needs some more testing.
WofWca
force-pushed
the
wofwca/fix-composer-focus
branch
from
1cf38c8
to
d708835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clearDraftwould get invoked fromsaveDraft()..focus()inside ofclearDraft()was introduced in 199ea23, most likely to re-focus the input after sending a message. We now have separate code for this, seecomposerSendMessage.This change likely needs some more testing.