Include Compiled Node Attributes in run_results.json #8492
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8492 +/- ##
==========================================
- Coverage 86.34% 86.34% -0.01%
==========================================
Files 174 174
Lines 25531 25541 +10
==========================================
+ Hits 22046 22054 +8
- Misses 3485 3487 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
peterallenwebb
requested review from
vadim82 and
martynydbt
and removed request for
a team
There was a problem hiding this comment.
tests/functional/invariants/invariants.py is kind of odd naming. Why "invariants"? Why the doubled up name? Is there some reason you put "get_run_results" in that file instead of in dbt/tests/util.py along with "get_manifest"?
Looks like artifacts tests need to be fixed...
@gshank I agree this was awkwardly named. The conditions I wound up calling "assertions" were initially "invariants" for nerdy reasons, but I thought calling them assertions was more friendly, and I should have made the naming consistent. Let me know what you think of the new names I chose.
Only that it didn't occur to me. I've moved the code to tests/util.py.
Fixed! |
* revert python version for docker images * add comment to not update python version, update changelog
* Update semantic model parsing tests to check measure non_additive_dimension spec * Make `window_groupings` default to empty list if not specified on `non_additive_dimension` * Add changie doc for `window_groupings` parsing fix
* add show test for json data * oh changie my changie * revert unecessary cahnge to fixture * keep decimal class for precision methods, but return __int__ value * jerco updates * update integer type * update other tests * Update .changes/unreleased/Fixes-20230803-093502.yaml --------- Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
* Improve docker image README - Fix unnecessary/missing newline escapes - Remove double whitespace between parameters - 2-space indent for extra lines in image build commands * Add changelog entry for #8212
* apply reformatting changes only for #8449 * add logging back to get_create_materialized_view_as_sql * changie
* update the implementation template * add colon
* add flaky decorator * split up tests into classes
…, fix msg format (#8451) * first pass, tests need updates * update proto defn * fixing tests * more test fixes * finish fixing test file * reformat the message * formatting messages * changelog * add event to unit test * feedback on message structure * WIP * fix up event to take in all fields * fix test
* Test `SemanticModel` satisfies protocol when none of it's `Optionals` are specified * Add tests ensuring SourceFileMetadata and FileSlice satisfiy DSI protocols * Add test asserting Defaults obj satisfies protocol * Add test asserting SemanticModel with optionals specified satisfies protocol * Split dimension protocol satisfaction tests into with and without optionals * Simplify DSI Protocol import strategy in protocol satisfaction tests * Add test asserting DimensionValidtyParams satisfies protocol * Add test asserting DimensionTypeParams satisfies protocol * Split entity protocol satisfaction tests into with and without optionals * Split measure protocol satisfication tests and add measure aggregation params satisficaition test * Split metric protocol satisfaction test into optional specified an unspecified Additionally, create where_filter pytest fixture * Improve protocol satisfaction tests for MetricTypeParams and sub protocols Specifically we added/improved protocol satisfaction tests for - MetricTypeParams - MetricInput - MetricInputMeasure - MetricTimeWindow
|
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#4125 |
resolves #7519
Problem
Solution
Checklist