Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-3013] Fix parsing of window_groupings #8454

Merged
merged 3 commits into from
Aug 18, 2023
Merged

[CT-3013] Fix parsing of window_groupings #8454

merged 3 commits into from
Aug 18, 2023

Conversation

QMalcolm
Copy link
Contributor

resolves #8453

Problem

window_groupings is supposed to be optional in user yaml specifications. However when not specified, parsing breaks. See #8453 for further details.

Solution

Default window_groupings to empty list when not specified

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@QMalcolm QMalcolm requested a review from a team as a code owner August 18, 2023 16:58
@QMalcolm QMalcolm requested a review from gshank August 18, 2023 16:58
@cla-bot cla-bot bot added the cla:yes label Aug 18, 2023
@codecov
Copy link

codecov bot commented Aug 18, 2023 •
edited
Loading

Codecov Report

Merging #8454 (ba5e1e7) into main (0553fd8) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8454      +/-   ##
==========================================
- Coverage   86.35%   86.31%   -0.05%     
==========================================
  Files         174      174              
  Lines       25568    25568              
==========================================
- Hits        22079    22068      -11     
- Misses       3489     3500      +11
Flag Coverage Δ
integration 83.09% <100.00%> (-0.11%) ⬇️
unit 65.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/contracts/graph/unparsed.py 93.10% <100.00%> (ø)

... and 3 files with indirect coverage changes

@QMalcolm QMalcolm merged commit 49397b4 into main Aug 18, 2023
59 of 60 checks passed
@QMalcolm QMalcolm deleted the ct-3013--ensure-non-additve-dimension-is-optional branch August 18, 2023 17:57
@github-actions
Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-8454-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 49397b4d7bcf0559cce06fcb52d5eccbd83f6ab7
# Push it to GitHub
git push --set-upstream origin backport-8454-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-8454-to-1.6.latest.

QMalcolm added a commit that referenced this pull request Aug 18, 2023
@QMalcolm
[CT-3013] Fix parsing of window_groupings (#8454)
eb3507b 
* Update semantic model parsing tests to check measure non_additive_dimension spec

* Make `window_groupings` default to empty list if not specified on `non_additive_dimension`

* Add changie doc for `window_groupings`  parsing fix
@QMalcolm QMalcolm mentioned this pull request Aug 18, 2023
Merged
QMalcolm added a commit that referenced this pull request Aug 22, 2023
@QMalcolm
[CT-3013] Fix parsing of window_groupings (#8454) (#8455)
4cfc662 
* Update semantic model parsing tests to check measure non_additive_dimension spec

* Make `window_groupings` default to empty list if not specified on `non_additive_dimension`

* Add changie doc for `window_groupings`  parsing fix
emmyoop pushed a commit that referenced this pull request Aug 23, 2023
@QMalcolm @emmyoop
[CT-3013] Fix parsing of window_groupings (#8454) (#8455)
38ac08e 
* Update semantic model parsing tests to check measure non_additive_dimension spec

* Make `window_groupings` default to empty list if not specified on `non_additive_dimension`

* Add changie doc for `window_groupings`  parsing fix
peterallenwebb pushed a commit that referenced this pull request Aug 30, 2023
@QMalcolm @peterallenwebb
[CT-3013] Fix parsing of window_groupings (#8454)
3769acd 
* Update semantic model parsing tests to check measure non_additive_dimension spec

* Make `window_groupings` default to empty list if not specified on `non_additive_dimension`

* Add changie doc for `window_groupings`  parsing fix
peterallenwebb added a commit that referenced this pull request Aug 30, 2023
@peterallenwebb @gshank
@McKnight-42 @FishtownBuildBot @QMalcolm @dave-connors-3 @emmyoop @jamezrin @mikealfare @MichelleArk
Include Compiled Node Attributes in run_results.json (#8492)
fc1a14a 
* Add compiled node properties to run_results.json

* Include compiled-node attributes in run_results.json

* Fix typo

* Bump schema version of run_results

* Fix test assertions

* Update expected run_results to reflect new attributes

* Code review changes

* Fix mypy warnings for ManifestLoader.load() (#8443)

* revert python version for docker images (#8445)

* revert python version for docker images

* add comment to not update python version, update changelog

* Bumping version to 1.7.0b1 and generate changelog

* [CT-3013]  Fix parsing of `window_groupings` (#8454)

* Update semantic model parsing tests to check measure non_additive_dimension spec

* Make `window_groupings` default to empty list if not specified on `non_additive_dimension`

* Add changie doc for `window_groupings`  parsing fix

* update `Number` class to handle integer values (#8306)

* add show test for json data

* oh changie my changie

* revert unecessary cahnge to fixture

* keep decimal class for precision methods, but return __int__ value

* jerco updates

* update integer type

* update other tests

* Update .changes/unreleased/Fixes-20230803-093502.yaml

---------

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>

* Improve docker image README (#8212)

* Improve docker image README

- Fix unnecessary/missing newline escapes
- Remove double whitespace between parameters
- 2-space indent for extra lines in image build commands

* Add changelog entry for #8212

* ADAP-814: Refactor prep for MV updates (#8459)

* apply reformatting changes only for #8449
* add logging back to get_create_materialized_view_as_sql
* changie

* swap trigger (#8463)

* update the implementation template (#8466)

* update the implementation template

* add colon

* Split tests into classes (#8474)

* add flaky decorator

* split up tests into classes

* revert update agate for int (#8478)

* updated typing and methods to meet mypy standards (#8485)

* Convert error to conditional warning for unversioned contracted model, fix msg format (#8451)

* first pass, tests need updates

* update proto defn

* fixing tests

* more test fixes

* finish fixing test file

* reformat the message

* formatting messages

* changelog

* add event to unit test

* feedback on message structure

* WIP

* fix up event to take in all fields

* fix test

* Fix ambiguous reference error for duplicate model names across packages with tests (#8488)

* Safely remove external nodes from manifest (#8495)

* [CT-2840] Improved semantic layer protocol satisfaction tests (#8456)

* Test `SemanticModel` satisfies protocol when none of it's `Optionals` are specified

* Add tests ensuring SourceFileMetadata and FileSlice satisfiy DSI protocols

* Add test asserting Defaults obj satisfies protocol

* Add test asserting SemanticModel with optionals specified satisfies protocol

* Split dimension protocol satisfaction tests into with and without optionals

* Simplify DSI Protocol import strategy in protocol satisfaction tests

* Add test asserting DimensionValidtyParams satisfies protocol

* Add test asserting DimensionTypeParams satisfies protocol

* Split entity protocol satisfaction tests into with and without optionals

* Split measure protocol satisfication tests and add measure aggregation params satisficaition test

* Split metric protocol satisfaction test into optional specified an unspecified

Additionally, create where_filter pytest fixture

* Improve protocol satisfaction tests for MetricTypeParams and sub protocols

Specifically we added/improved protocol satisfaction tests for
- MetricTypeParams
- MetricInput
- MetricInputMeasure
- MetricTimeWindow

* Convert to using mashumaro jsonschema with acceptable performance (#8437)

* Regenerate run_results schema after merging in changes from main.

---------

Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
Co-authored-by: Matthew McKnight <91097623+McKnight-42@users.noreply.github.com>
Co-authored-by: Github Build Bot <buildbot@fishtownanalytics.com>
Co-authored-by: Quigley Malcolm <QMalcolm@users.noreply.github.com>
Co-authored-by: dave-connors-3 <73915542+dave-connors-3@users.noreply.github.com>
Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
Co-authored-by: Jaime Martínez Rincón <jaime@jamezrin.name>
Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
Co-authored-by: Michelle Ark <MichelleArk@users.noreply.github.com>
@tlento tlento mentioned this pull request Nov 6, 2023
Merged
5 tasks
@tlento tlento mentioned this pull request Feb 26, 2024
Merged
@aranke aranke mentioned this pull request Jul 12, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

@peterallenwebb peterallenwebb peterallenwebb approved these changes

Assignees
No one assigned
Labels
backport 1.6.latest cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-3013] [Bug] non_additive_dimension property window_groupings should be optional but isn't
3 participants
@QMalcolm @gshank @peterallenwebb