add target-path to more cli commands that use it. #7647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwreeves
requested review from
aranke and
VersusFacit
and removed request for
a team
stu-k
reviewed
May 16, 2023
stu-k
approved these changes
May 16, 2023
|
@jtcohen6 would you approve backporting this one? |
2 tasks
|
@dbeatty10 Good by me! Sorry I missed this comment last month |
jtcohen6
pushed a commit
that referenced
this pull request
Jun 27, 2023
jtcohen6
added a commit
that referenced
this pull request
Jun 28, 2023
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7646
Description
Related to my previous PR #7419 and issue #7418.
There are additional subcommands that do not have
--target-pathas an option, even though they create atarget/folder when one does not exist. Because we (at our company with our dbt setup) do not have our target set up in${PWD}/target, and we specify the--target-pathvia the CLI, this ends up being an annoyance.In particular, we were using dbt 1.1.x and ran into this as a regression for the command
dbt run-operation. However, I went through the rest of the CLI and added--target-pathfor everything that met the following criteria:${PWD}/target/does not exist.dbt [subcommand].${PWD}/target/does exist.I also validated this against source code, e.g.
GraphRunnableTaskusesself.config.target_path, so all subclasses of this should have a--target-path.Checklist
changie newto create a changelog entry