Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2443] [Regression] dbt snapshot command uses target path, but does not have a CLI option to specify it. #7418

Closed
2 tasks done
dwreeves opened this issue Apr 20, 2023 · 2 comments · Fixed by #7419
Closed
2 tasks done
Labels
bug Something isn't working pre-regression Regression not yet in a stable release regression

Comments

@dwreeves
Copy link
Contributor

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

the dbt snapshot command does not have a --target-path option.

Expected Behavior

Because the dbt snapshot command uses the target path as part of its runtime, I expected that you would also be able to specify it. This is also a regression from our end (we are upgrading from dbt 1.1 to 1.5), as we were using a custom target path to run everything out of.

Steps To Reproduce

Attempt the command dbt snapshot --target-path my/custom/path.

Relevant log output

No response

Environment

- OS: OSX
- Python: 3.10
- dbt: 1.5 beta

Which database adapter are you using with dbt?

snowflake

Additional Context

No response

@dwreeves dwreeves added bug Something isn't working triage labels Apr 20, 2023
@github-actions github-actions bot changed the title [Bug] dbt snapshot command uses target path, but does not have a CLI option to specify it. [CT-2443] [Bug] dbt snapshot command uses target path, but does not have a CLI option to specify it. Apr 20, 2023
@dbeatty10 dbeatty10 self-assigned this Apr 20, 2023
@dbeatty10
Copy link
Contributor

Thanks for trying out 1.5 and reporting this @dwreeves 🏅

I suspect that the behavior you are seeing is because @p.target_path is missing from here:

# dbt snapshot
@cli.command("snapshot")
@click.pass_context
@p.defer
@p.deprecated_defer
@p.exclude
@p.favor_state
@p.deprecated_favor_state
@p.profile
@p.profiles_dir
@p.project_dir
@p.select
@p.selector
@p.state
@p.deprecated_state
@p.target
@p.threads
@p.vars

I'm going to re-label this as a regression.

@dbeatty10 dbeatty10 removed their assignment Apr 20, 2023
@dbeatty10
Copy link
Contributor

Lol, I just noticed you already realized the fix and submitted #7419 accordingly. Thanks for doing that @dwreeves!

@dbeatty10 dbeatty10 changed the title [CT-2443] [Bug] dbt snapshot command uses target path, but does not have a CLI option to specify it. [CT-2443] [Regression] dbt snapshot command uses target path, but does not have a CLI option to specify it. Apr 20, 2023
@dbeatty10 dbeatty10 added the pre-regression Regression not yet in a stable release label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pre-regression Regression not yet in a stable release regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants