Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid saving secrets in SecretContext #4664

Closed
wants to merge 2 commits into from
Closed

Avoid saving secrets in SecretContext #4664

wants to merge 2 commits into from

Conversation

nathaniel-may
Copy link
Contributor

resolves #4650

Description

Prevents saving secret environment variables so that partial parsing doesn't get triggered on secret changes.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Feb 2, 2022
@nathaniel-may nathaniel-may changed the base branch from main to 1.0.latest February 2, 2022 23:02
@nathaniel-may
Copy link
Contributor Author

Accidentally branched from 1.0.latest instead of main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-114] Avoid saving secrets in SecretContext
1 participant
@nathaniel-may