Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-114] Avoid saving secrets in SecretContext #4650

Closed
jtcohen6 opened this issue Jan 31, 2022 · 0 comments · Fixed by #4665
Closed

[CT-114] Avoid saving secrets in SecretContext #4650

jtcohen6 opened this issue Jan 31, 2022 · 0 comments · Fixed by #4665
Assignees
@nathaniel-may
Labels
bug Something isn't working partial_parsing
Milestone
v1.0.2

Comments

@jtcohen6
Copy link
Contributor

From #4642 (comment):

The place that needs to be fixed is in core/dbt/context/secret.py, in the env_var method. Where it saved the return_value in self.env_vars, we want to skip saving if the env_var if it starts with the SECRET_ENV_PREFIX.

(feel free to update with more details)
@jtcohen6 jtcohen6 added this to the v1.0.2 milestone Jan 31, 2022
@github-actions github-actions bot changed the title Avoid saving secrets in SecretContext [CT-114] Avoid saving secrets in SecretContext Jan 31, 2022
This was referenced Jan 31, 2022
Closed
Closed
@nathaniel-may nathaniel-may self-assigned this Feb 1, 2022
This was referenced Feb 2, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nathaniel-may nathaniel-may

Labels
bug Something isn't working partial_parsing
Projects
None yet
Milestone
v1.0.2
2 participants
@nathaniel-may @jtcohen6