Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-create purged cluster for databricks_mount for AWS S3 #1345

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

nfx
Copy link
Contributor

@nfx nfx commented May 30, 2022

Fix #1317

@nfx nfx changed the title Re-create purged cluster for databricks_mount Re-create purged cluster for databricks_mount for AWS S3 May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1345 (b7d0c66) into master (75e5573) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
+ Coverage   90.08%   90.10%   +0.01%     
==========================================
  Files         121      121              
  Lines       10120    10123       +3     
==========================================
+ Hits         9117     9121       +4     
+ Misses        639      638       -1     
  Partials      364      364              
Impacted Files Coverage Δ
storage/aws_s3_mount.go 87.50% <100.00%> (+0.75%) ⬆️
storage/s3.go 90.00% <100.00%> (+1.76%) ⬆️

@nfx nfx merged commit 1366de3 into master May 30, 2022
@nfx nfx deleted the issue/1317 branch May 30, 2022 19:46
nfx added a commit that referenced this pull request May 30, 2022
## 0.5.9

* Added warning section for debug mode ([#1325](#1325)).
* Added ability to specify tags for `databricks_job` ([#1337](#1337)).
* Upgraded AWS provider for AWS guides. Added examples for account-level identities ([#1332](#1332)).
* Updated docs to use `application_id` as privilege for `databricks_service_principal` ([#1336](#1336)).
* Added `databricks_service_principal_role` resource ([#1340](#1340)).
* Fixed itegration testing image ([#1342](#1342), [#1343](#1343)).
* Added `skip_validation` for `databricks_external_location` ([#1330](#1330)).
* Added `alert_on_last_attempt` to `databricks_job` ([#1341](#1341)).
* Skip `make test` on doc-only changes ([#1339](#1339)).
* Improve common package test coverage ([#1344](#1344)).
* Re-create purged cluster for `databricks_mount` for AWS S3 ([#1345](#1345)).

Updated dependency versions:

* Bump google.golang.org/api from 0.79.0 to 0.80.0
* Bump github.com/Azure/go-autorest/autorest/adal from 0.9.19 to 0.9.20
@nfx nfx mentioned this pull request May 30, 2022
@ebarault
Copy link

ebarault commented Jun 3, 2022

@nfx hi, will this handle the case where we do not use the by-default-created cluster from the resource, but use an existing custom cluster that has been deleted in the meantime ?

@nfx
Copy link
Contributor Author

nfx commented Jun 3, 2022

it should. please open new issue if it persists

michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] databricks_mount issue when cluster used to create mount no longer exists
2 participants