Chore/improve client #1344
Merged
Chore/improve client #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nfx
commented
May 30, 2022
•
nfx
commented
- Make client error messages friendlier
- Allow passing io.Reader as request body
- Increase test coverage for common/http.go
- Moved TrimLeadingWhitespace from internal to commands
Codecov Report
@@ Coverage Diff @@
## master #1344 +/- ##
==========================================
- Coverage 90.57% 90.08% -0.49%
==========================================
Files 119 121 +2
Lines 10022 10120 +98
==========================================
+ Hits 9077 9117 +40
- Misses 564 639 +75
+ Partials 381 364 -17
|
nfx
added a commit
that referenced
this pull request
May 30, 2022
## 0.5.9 * Added warning section for debug mode ([#1325](#1325)). * Added ability to specify tags for `databricks_job` ([#1337](#1337)). * Upgraded AWS provider for AWS guides. Added examples for account-level identities ([#1332](#1332)). * Updated docs to use `application_id` as privilege for `databricks_service_principal` ([#1336](#1336)). * Added `databricks_service_principal_role` resource ([#1340](#1340)). * Fixed itegration testing image ([#1342](#1342), [#1343](#1343)). * Added `skip_validation` for `databricks_external_location` ([#1330](#1330)). * Added `alert_on_last_attempt` to `databricks_job` ([#1341](#1341)). * Skip `make test` on doc-only changes ([#1339](#1339)). * Improve common package test coverage ([#1344](#1344)). * Re-create purged cluster for `databricks_mount` for AWS S3 ([#1345](#1345)). Updated dependency versions: * Bump google.golang.org/api from 0.79.0 to 0.80.0 * Bump github.com/Azure/go-autorest/autorest/adal from 0.9.19 to 0.9.20
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
* Make client error messages friendlier * Allow passing `io.Reader` as request body * Increase test coverage for `common/http.go` * Moved `TrimLeadingWhitespace` from `internal` to `commands`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.