test: add "cypress-in-cypress" tests for navigating in and out of spec runner #19845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
tbiethman
approved these changes
Jan 24, 2022
elevatebart
approved these changes
Jan 24, 2022
Definitely. We should be able to check the resizing (currently just component tested), and some settings stuff, now too. |
tgriesser
added a commit
that referenced
this pull request
Jan 26, 2022
* 10.0-release: test: add "cypress-in-cypress" tests for navigating in and out of spec runner (#19845) chore: add test cases for migration (#19905) test: fix launchpad flake caused by unoptimized deps (#19903) feat: launchpad browser select (#19830) fix: increase timeout in cy.contains to avoid flake refactor: Remove connection on specs, increase pagination limits elsewhere (#19881) fix(unify): Fixing launchpad project setup tests (#19886) test(unify): Specs Page Workflows - E2E/Component (#19780) feat: migration rename files (#19807) chore: remove design system warnings (#19851)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently merged #19835 did not take advantage of Cypress-In-Cypress testing to prevent regressions, adding it now.
Additional details
To verify that these updates would catch the regression, comment out
initialized.value = falseon line 18 of unifiedRunner.tsRun the
cypress-in-cypress-e2e.cy.tsandcypress-in-cypress-component.cy.tsapp e2e specs and verify the test fornavigation between specs and other parts of the app worksfails as the spec runner does not reopen when the test tries to visit it.Uncomment the
initialized.value = falseand rerun the tests, they should pass now.There is some duplication between the tests and I think for now that's fine. It seems like with Cypress In Cypress we will have several kinds of tests that we want to re-run in both testing modes so some pattern for sharing code between specs will be useful.
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?