test(unify): Specs Page Workflows - E2E/Component #19780

tbiethman · 2022-01-20T05:57:11Z

Closes Unification App: Write E2E tests around "Specs Page" - New component testing project #19207 Unification App: Write E2E tests around "Specs Page" - New e2e testing project #19208

This PR adds coverage for the Specs page for both E2E and component testing projects. Some existing tests were modified to align with new tests to reduce duplication, and a few were removed if they have coverage elsewhere. Existing TODOs were cleaned up as much as possible.

User facing changelog

N/A

Additional details

The following reqs are accounted for here: TODO

How has the user experience changed?

PR Tasks

Have tests been added/updated?
Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
[n/a] Has a PR for user-facing changes been opened in cypress-documentation?
[n/a] Have API changes been updated in the type definitions?
[n/a] Have new configuration options been added to the cypress.schema.json?

cypress-bot · 2022-01-20T05:57:13Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

packages/app/src/pages/Specs/Index.vue

cypress · 2022-01-20T06:07:50Z

Test summary

17913 • 0 • 216 • 0 • 5

Run details


Project	cypress
Status	Passed
Commit	`6db03f1`
Started	Jan 24, 2022 7:12 PM
Ended	Jan 24, 2022 7:23 PM
Duration	11:43 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

Flakiness

	commands/net_stubbing.cy.ts	2
1	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
	cypress/proxy-logging.cy.ts	3
1	... > works with forceNetworkError
2	Proxy Logging > request logging > xhr log has response body/status code
3	... > works with forceNetworkError

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

packages/frontend-shared/src/gql-components/OpenConfigFileInIDE.vue

tbiethman · 2022-01-20T06:10:26Z

system-tests/projects/no-specs-custom-pattern/.storybook/main.js

@@ -0,0 +1,12 @@
+module.exports = {


Three new system-test projects were added in this PR. Lots of files, some duplication, but utilizing these gives us as much e2e coverage as possible (as compared to config interceptions).

…into issue-19207-specs-page-ct

packages/data-context/src/codegen/spec-options.ts

system-tests/projects/no-specs-no-storybook/cypress.config.js

…into issue-19207-specs-page-ct

marktnoonan

Just one change request on the button that was removed, I think we should come at that a different way. Overall this is super.

packages/app/src/specs/CustomPatternNoSpecContent.vue

packages/frontend-shared/src/gql-components/OpenConfigFileInIDE.vue

packages/app/src/pages/Specs/Index.vue

…into issue-19207-specs-page-ct # Conflicts: # packages/app/cypress/e2e/index.cy.ts

system-tests/projects/no-specs-custom-pattern/cypress.config.js

…test

emilyrohrbough · 2022-01-21T22:36:42Z

packages/app/cypress/e2e/index.cy.ts

+        cy.findByRole('link', { name: defaultMessages.createSpec.viewSpecPatternButton })
+        .should('be.visible')
+        .and('not.be.disabled')
+        .and('have.attr', 'href', '#/settings?section=project&setting=specPattern')


is this href at risk of changing?

Not in the short term. Medium term, this type of deeplink to the spec pattern will be replaced with a modal the opens and displays the spec pattern directly. But for now, the settings page is explicitly looking for this query param to decide where to scroll, so it's a pretty stable situation and we'd only want to change this URL if that implementation changed.

@marktnoonan is there an issue logged to update to the modal pattern? I wasn't able to find one.

@tbiethman there was an issue, but recently closed as we believe this change has been dropped from 10.0. But it is still in Figma and I expect it will come around soon enough even if not present during release. It's probably a nicer experience to just peek at the spec pattern instead of leaving the current page.

@tbiethman I stand corrected, @ZachJW34 has this change completed as part of other spec pattern work in this PR, so whichever merges last can align the test with the new behavior.

@marktnoonan I'll keep an eye on that PR. It doesn't change the specs page implementation, at least as it stands. But if the component work is done, it might make sense to re-open that issue and hook this up prior to release.

packages/app/cypress/e2e/index.cy.ts

emilyrohrbough · 2022-01-21T22:40:28Z

packages/app/cypress/e2e/index.cy.ts

+          cy.get('@EmptySpecCard').click()
+          cy.contains('button', defaultMessages.components.button.cancel).click()
+          cy.get('[data-cy="create-spec-modal"]').within(() => {
+            cy.get('[data-cy="card"]').contains(defaultMessages.createSpec.e2e.importEmptySpec.header).click()


Suggested change

cy.get('[data-cy="card"]').contains(defaultMessages.createSpec.e2e.importEmptySpec.header).click()

cy.get('[data-cy="card"]')

.contains(defaultMessages.createSpec.e2e.importEmptySpec.header)

.click()

packages/app/cypress/e2e/index.cy.ts

* 10.0-release: test: add "cypress-in-cypress" tests for navigating in and out of spec runner (#19845) chore: add test cases for migration (#19905) test: fix launchpad flake caused by unoptimized deps (#19903) feat: launchpad browser select (#19830) fix: increase timeout in cy.contains to avoid flake refactor: Remove connection on specs, increase pagination limits elsewhere (#19881) fix(unify): Fixing launchpad project setup tests (#19886) test(unify): Specs Page Workflows - E2E/Component (#19780) feat: migration rename files (#19807) chore: remove design system warnings (#19851)

tbiethman added 2 commits January 19, 2022 18:21

Adding component testing workflow coverage to specs (index) page.

df2c5a3

Adding e2e tests as well

d2ea958

tbiethman mentioned this pull request Jan 20, 2022

test(unify): Specs Page Workflows - Component Tests #19659

Closed

2 tasks

tbiethman commented Jan 20, 2022

View reviewed changes

packages/app/src/pages/Specs/Index.vue Show resolved Hide resolved

tbiethman commented Jan 20, 2022

View reviewed changes

packages/frontend-shared/src/gql-components/OpenConfigFileInIDE.vue Outdated Show resolved Hide resolved

tbiethman commented Jan 20, 2022

View reviewed changes

tbiethman linked an issue Jan 20, 2022 that may be closed by this pull request

Unification App: Write E2E tests around "Specs Page" - New e2e testing project #19208

Closed

tbiethman added 2 commits January 20, 2022 00:16

Merge branch '10.0-release' of https://github.com/cypress-io/cypress …

c266d01

…into issue-19207-specs-page-ct

Fixing some component tests and types

854337d

jennifer-shehane requested review from marktnoonan and emilyrohrbough January 20, 2022 16:37

Adding test for spec page navigation

4fb3dab

tbiethman self-assigned this Jan 20, 2022

tbiethman commented Jan 20, 2022

View reviewed changes

packages/data-context/src/codegen/spec-options.ts Show resolved Hide resolved

Updating formatting

6edc312

emilyrohrbough reviewed Jan 20, 2022

View reviewed changes

system-tests/projects/no-specs-no-storybook/cypress.config.js Outdated Show resolved Hide resolved

tbiethman added 4 commits January 21, 2022 09:09

Merge branch '10.0-release' of https://github.com/cypress-io/cypress …

fee258f

…into issue-19207-specs-page-ct

Updating tests with flake

f400f45

Whoops wrong one

f10065e

Trying to hunt down some flakiness

6d6cef6

marktnoonan requested changes Jan 21, 2022

View reviewed changes

tbiethman added 2 commits January 21, 2022 14:22

Still hunting.

44418dc

Merge branch '10.0-release' of https://github.com/cypress-io/cypress …

037c99f

…into issue-19207-specs-page-ct # Conflicts: # packages/app/cypress/e2e/index.cy.ts

emilyrohrbough reviewed Jan 21, 2022

View reviewed changes

system-tests/projects/no-specs-custom-pattern/cypress.config.js Show resolved Hide resolved

Reverting open IDE button change. Trying different selector for code …

3447115

…test

emilyrohrbough reviewed Jan 21, 2022

View reviewed changes

packages/app/cypress/e2e/index.cy.ts Outdated Show resolved Hide resolved

emilyrohrbough reviewed Jan 21, 2022

View reviewed changes

packages/app/cypress/e2e/index.cy.ts Show resolved Hide resolved

emilyrohrbough previously approved these changes Jan 21, 2022

View reviewed changes

Skipping flaky code presentation

351f5f2

tbiethman dismissed emilyrohrbough’s stale review via 351f5f2 January 21, 2022 23:11

marktnoonan and others added 2 commits January 24, 2022 08:26

Merge branch '10.0-release' into issue-19207-specs-page-ct

b49f96e

Last couple changes

8ac68ab

tbiethman requested review from marktnoonan and emilyrohrbough January 24, 2022 16:31

marktnoonan and others added 2 commits January 24, 2022 13:35

Merge branch '10.0-release' into issue-19207-specs-page-ct

a55353b

Importing ref

6db03f1

emilyrohrbough approved these changes Jan 25, 2022

View reviewed changes

marktnoonan approved these changes Jan 25, 2022

View reviewed changes

tbiethman merged commit 3bc529b into 10.0-release Jan 25, 2022

tbiethman deleted the issue-19207-specs-page-ct branch January 25, 2022 15:50

cypress-bot bot mentioned this pull request Jan 25, 2022

Unification App: Write E2E tests around "Specs Page" - New component testing project #19207

Closed

tbiethman mentioned this pull request Jan 25, 2022

Unification App: Write E2E tests around "Specs Page" - New e2e testing project #19208

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(unify): Specs Page Workflows - E2E/Component #19780

test(unify): Specs Page Workflows - E2E/Component #19780

tbiethman commented Jan 20, 2022 •

edited

Loading

cypress-bot bot commented Jan 20, 2022

cypress bot commented Jan 20, 2022 •

edited

Loading

tbiethman Jan 20, 2022 •

edited

Loading

marktnoonan left a comment •

edited

Loading

emilyrohrbough Jan 21, 2022

marktnoonan Jan 21, 2022

tbiethman Jan 21, 2022

marktnoonan Jan 23, 2022

marktnoonan Jan 24, 2022

tbiethman Jan 24, 2022

emilyrohrbough Jan 21, 2022

test(unify): Specs Page Workflows - E2E/Component #19780

test(unify): Specs Page Workflows - E2E/Component #19780

Conversation

tbiethman commented Jan 20, 2022 • edited Loading

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

cypress-bot bot commented Jan 20, 2022

cypress bot commented Jan 20, 2022 • edited Loading

Test summary

Run details

Flakiness

tbiethman Jan 20, 2022 • edited Loading

Choose a reason for hiding this comment

marktnoonan left a comment • edited Loading

Choose a reason for hiding this comment

emilyrohrbough Jan 21, 2022

Choose a reason for hiding this comment

marktnoonan Jan 21, 2022

Choose a reason for hiding this comment

tbiethman Jan 21, 2022

Choose a reason for hiding this comment

marktnoonan Jan 23, 2022

Choose a reason for hiding this comment

marktnoonan Jan 24, 2022

Choose a reason for hiding this comment

tbiethman Jan 24, 2022

Choose a reason for hiding this comment

emilyrohrbough Jan 21, 2022

Choose a reason for hiding this comment

tbiethman commented Jan 20, 2022 •

edited

Loading

cypress bot commented Jan 20, 2022 •

edited

Loading

tbiethman Jan 20, 2022 •

edited

Loading

marktnoonan left a comment •

edited

Loading