Implement CS3APIs datatx name change PullTransfer -> CreateTransfer #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redblom
requested review from
labkode,
gmgigi96,
glpatcern and
a team
as code owners
redblom
force-pushed
the
rclone-tpc-cs3apis
branch
from
f8707d5
to
0659a8d
Compare
glpatcern
requested changes
Jan 24, 2023
There was a problem hiding this comment.
Hi there, I see you sorted out Reva with the rebase, at this point let's make things clearer - we're also cleaning up the other OCM properties including having datatx as a protocol type, see cs3org/OCM-API#57
Therefore I propose you to also add the opaque parameters as real ones.
redblom
force-pushed
the
rclone-tpc-cs3apis
branch
from
0659a8d
to
6426036
Compare
redblom
changed the title
glpatcern
approved these changes
Feb 1, 2023
redblom
changed the title
glpatcern
requested changes
Feb 10, 2023
redblom
force-pushed
the
rclone-tpc-cs3apis
branch
from
5623ec9
to
648a425
Compare
glpatcern
approved these changes
Feb 13, 2023
vascoguita
pushed a commit
to vascoguita/reva
that referenced
this pull request
Feb 14, 2023
…s3org#3553) * Implement CS3APIs datatx message name change. * Add #PR * Bindings to make CI pass * Opaque field ShareId promoted to real message property. * Temporary reference to upcoming/to-be-merged CS3APIs change. * Normalize before url parsing if necessary. * Lint fixes. * Lint fixes. * Cleanup lines. * Revert to new go bindings. --------- Co-authored-by: Antoon P <antoon@redblom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaking change implements the CS3APIs name change PullTransfer -> CreateTransfer (requires: cs3org/cs3apis#195).