Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name change in module datatx: PullTransfer -> CreateTransfer #195

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Name change in module datatx: PullTransfer -> CreateTransfer #195

merged 3 commits into from
Feb 7, 2023

Conversation

redblom
Copy link
Contributor

@redblom redblom commented Jan 16, 2023

Deals with #189
This is a breaking change.

@redblom redblom requested a review from labkode as a code owner January 16, 2023 12:43
@redblom redblom mentioned this pull request Jan 16, 2023
Merged
@glpatcern glpatcern self-requested a review January 17, 2023 12:29
glpatcern
glpatcern approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the famous rename that got the CI changes in the way - sorry for that. I think it's all fine but can you rebase on top of current main? and also, I guess we have to merge this and the corresponding Reva code change at the same time, right?

@redblom
Copy link
Contributor Author

redblom commented Jan 18, 2023

This is the famous rename that got the CI changes in the way - sorry for that. I think it's all fine but can you rebase on top of current main?

Done

and also, I guess we have to merge this and the corresponding Reva code change at the same time, right?

Yes that would be cs3org/reva#3553

redblom pushed a commit to redblom/go-cs3apis that referenced this pull request Jan 23, 2023
@antoonp
Bindings for cs3org/cs3apis#195
c1e598e
redblom pushed a commit to redblom/go-cs3apis that referenced this pull request Jan 23, 2023
@antoonp
Bindings for cs3org/cs3apis#195
f55fe94
@glpatcern glpatcern self-requested a review January 24, 2023 15:20
@glpatcern glpatcern merged commit 194e643 into cs3org:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redblom @glpatcern @antoonp