Fix #3550: OCM share fails for json driver

[redblom]

Fixes implementation omission in ocm share json driver in #3526

[redblom]

Ps. Tested locally. Both OCM sharing and transfers successful.

[michielbdejong]

Thanks! Sorry if this broke for you! We were in a bit of a hurry to merge last week. :)

One remark: I notice you used fmt.Sprintf("%s@%s", userID.OpaqueId, userID.Idp) instead of fmt.Sprintf("%s@%s", userID.OpaqueId, sm.webDAVHost) which may be fine depending on which service is used as the WebDAV server, right?

I guess if you run Reva's ocdav module then userID.Idp works?
Does this work with the ocdav module?

[redblom]

One remark: I notice you used fmt.Sprintf("%s@%s", userID.OpaqueId, userID.Idp) instead of fmt.Sprintf("%s@%s", userID.OpaqueId, sm.webDAVHost) which may be fine depending on which service is used as the WebDAV server, right?

I guess if you run Reva's ocdav module then userID.Idp works? Does this work with the ocdav module?

Well, originally this was the 'meshProvider' (user.idp), this fix still works for this driver with ocdav. The webDAVHost is not available in the json driver.
Is the ratio behind (sending) this (new) webDAVHost config by the nextcloud driver discussed somewhere? Can't seem to find that.

[michielbdejong]

Is the ratio behind (sending) this (new) webDAVHost config by the nextcloud driver discussed somewhere? Can't seem to find that.

Good point, it wasn't so far but I added
this page
to the Reva configuration docs just now.

I created https://reva.link/docs/config/grpc/services/ocmshareprovider/ and so far listed only the Nextcloud driver.

That explains how to configure your EFSS as the webdav host. About the discussion about whether the EFSS or Reva should act as webdav host, I think from the start the plan was to make Reva the webdav host, but I felt that this would just become too slow. I must I haven't tried using Reva with ocdav in front of the EFSS, I guess in theory it should work!

[glpatcern]

That explains how to configure your EFSS as the webdav host. About the discussion about whether the EFSS or Reva should act as webdav host, I think from the start the plan was to make Reva the webdav host, but I felt that this would just become too slow. I must I haven't tried using Reva with ocdav in front of the EFSS, I guess in theory it should work!

I agree it does make sense to expose the "real" EFSS as the webdav host. We'd expose Reva when Reva is the EFSS engine (i.e. future OCIS systems or current CERNBox).