Efss backend fixes #3526
Merged
Efss backend fixes #3526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to efss-backend-fixes
michielbdejong
requested review from
labkode,
gmgigi96,
glpatcern and
a team
as code owners
|
Thanks for creating a PR from your fork. This way the CI will run even faster since more runners are available to work in parallel (we just have 8 self-hosted runners so far). |
vascoguita
reviewed
Dec 7, 2022
|
@gmgigi96 it's green now :) |
glpatcern
approved these changes
Dec 7, 2022
gmgigi96
requested changes
Dec 7, 2022
| log.Info().Msgf("pkg/ocm/share/manager/json providerId: %s", fmt.Sprintf("%s:%s", md.StorageId, md.OpaqueId)) | ||
| log.Info().Msgf("pkg/ocm/share/manager/json owner: %s", userID.OpaqueId) | ||
| log.Info().Msgf("pkg/ocm/share/manager/json protocol: %s", protocol) | ||
| log.Info().Msgf("pkg/ocm/share/manager/json meshProvider: %s", userID.Idp) |
There was a problem hiding this comment.
These seems to be debug logs, can you remove them? Or log them better?
| }, | ||
| } | ||
| } | ||
|
|
||
| log := appctx.GetLogger(ctx) | ||
| log.Info().Msg("pkg/ocm/share/manager/nextcloud calls sender.Send") |
| @@ -498,33 +543,32 @@ func (sm *Manager) ListReceivedShares(ctx context.Context) ([]*ocm.ReceivedShare | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| var pointers = make([]*ocm.ReceivedShare, len(respArr)) | |||
| var pointersBaseShare = make([]*ocm.Share, len(respArr)) | |||
| var pointersReceivedShare = make([]*ocm.ReceivedShare, len(respArr)) | |||
| for i := 0; i < len(respArr); i++ { | |||
There was a problem hiding this comment.
Use a for-range loop here.
pointersBaseShare should be initialized with make([]*ocm.Share, 0, len(respArr))
| } | ||
| return nil, errors.New("received an unreadable share object from the EFSS backend") | ||
| } | ||
| pointersBaseShare[i] = &ocm.Share{ |
There was a problem hiding this comment.
use the append function to add the struct to the list
| user, err := getUser(ctx) | ||
| if err != nil { | ||
| // log.Error().Msg("error getting user!") |
There was a problem hiding this comment.
please remove all these commented lines
Merged
This was referenced Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3524