-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More dav unit tests #3461
More dav unit tests #3461
Conversation
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
a7d20b1
to
85d34f4
Compare
…ror cases Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
c36e79e
to
c722cfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides the nitpicks
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic could you add to master as well? |
😍 lgtm |
@labkode we started refactoring the error handling, the added tests make use of the error returned by the handlers ... we also moved to ginkgo/v2 ... urgh ... so I cannot even just add the test because they make use of DescribeTable which is only in ginkgo v2 ... most of these cases are covered by the acceptance tests, we just want to develop unit tests to improve the coverage and then refactor the handlers further. |
brings ocdav coverage to 16.8%