-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Tags pkg #3564
Fix Tags pkg #3564
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
f362d95
to
5eafdf2
Compare
just a idea: type Tags struct {
t []string
}
func NewTags(in ...string) *Tags {
t := &Tags{}
for _, tgs := range in {
t.t = append(t.t, strings.Split(tgs, ",")...)
}
return t
} then we do not have to differentiate between |
5eafdf2
to
c090391
Compare
Excellent idea 👍 Just named it |
c090391
to
0706081
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
0706081
to
e9a5eba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
adds an option to create the tags struct from a
[]string