Dav unit tests #3441
Merged
Dav unit tests #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested review from
labkode,
wkloucek,
glpatcern,
a team and
ishank011
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
dav-unit-tests
branch
from
d340664
to
4e5722e
Compare
butonic
force-pushed
the
dav-unit-tests
branch
from
4e5722e
to
a91cc7a
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
aduffeck
requested changes
Nov 10, 2022
| @@ -226,6 +227,13 @@ func NewWith(conf *Config, fm favorite.Manager, ls LockSystem, _ *zerolog.Logger | |||
| if err := s.davHandler.init(conf); err != nil { | |||
| return nil, err | |||
| } | |||
| if gwc == nil { | |||
| var err error | |||
| s.gwClient, err = pool.GetGatewayServiceClient(s.c.GatewaySvc) | |||
There was a problem hiding this comment.
How about moving this default behavior into New and just erroring out in here if the given client is nil?
There was a problem hiding this comment.
I would have to duplicate it to pkg/micro/ocdav/service.go as well, otherwise we would change the behavior of the micro ocdav service, requiring a major version bump. So I put the fallback here, to make passing in a gwclient optional.
73 tasks
49 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added unit tests to cover more ocdav handlers:
part of owncloud/ocis#5022