Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional existingLockID to RefreshLockRequest in the decomposedFS #3286

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

micbar
Copy link
Member

@micbar micbar commented Sep 29, 2022

Enhancement: Make Refresh Lock operation WOPI compliant

We now support the WOPI compliant UnlockAndRelock operation. This has been implemented in the DecomposedFS. To make use of it, we need a compatible WOPI server.

https://learn.microsoft.com/en-us/microsoft-365/cloud-storage-partner-program/rest/files/unlockandrelock

Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, yet considering the pure refreshLock logic also "correct" if the existing lock is simply overwritten (the eosfs way).

Will patch that one as well to take the new argument into account of course, but could you please push this to master?

@micbar
Copy link
Member Author

micbar commented Sep 29, 2022

@glpatcern please check out #3289 for the master branch.

Unfortunately we have no PreconditionFailed Return code on master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants