decomposedfs now ignores the idp #3266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@micbar we never persisted the Idp for the grantee and there was actually a bug that dropped the creator when updating a share which this pr fixes as well... 🤞 |
butonic
force-pushed
the
decomposedfs-drop-idp
branch
3 times, most recently
from
7202710
to
93622bc
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
This was referenced Sep 23, 2022
butonic
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
|
owncloud/ocis#4658 is green |
kobergj
approved these changes
Sep 26, 2022
|
@kobergj yep, ocis pipeline was green https://drone.owncloud.com/owncloud/ocis/15713 |
9 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer persist the IDP of a user id in decomposedfs grants. As a consequence listing or reading Grants no longer returns the Idp for the Creator.
It never did for the Grantee. Whatever credentials are used to authenticate a user we internally have to create a uuid anyway. Either by lookung it up in an external service (eg. LDAP or SIEM) or we autoprovision it.
Signed-off-by: Jörn Friedrich Dreyer jfd@butonic.de