Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Update expected to fail file edge #2910

Merged
merged 1 commit into from
Jun 7, 2022
Merged

[tests-only][full-ci]Update expected to fail file edge #2910

merged 1 commit into from
Jun 7, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jun 1, 2022 •
edited
Loading

@SwikritiT SwikritiT mentioned this pull request Jun 1, 2022
Closed
11 tasks
@SwikritiT SwikritiT force-pushed the update-expected-to-fail-file-edge branch from 548834b to 080d0de Compare June 1, 2022 09:03
@phil-davis phil-davis self-requested a review June 1, 2022 09:11
@SwikritiT SwikritiT force-pushed the update-expected-to-fail-file-edge branch 6 times, most recently from 3a7643f to 38d847d Compare June 2, 2022 10:45
@kiranparajuli589 kiranparajuli589 mentioned this pull request Jun 6, 2022
Closed
14 tasks
@SwikritiT SwikritiT force-pushed the update-expected-to-fail-file-edge branch from 125c2d1 to 1b25649 Compare June 6, 2022 11:31
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT marked this pull request as ready for review June 7, 2022 03:43
phil-davis
phil-davis approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. It will be good to get this merged now (and similar changes for master #2917 ). And then we can continue going through expected-failures and looking at diffs between reva master, reva edge and oCIS, and document carefully what is the current real issue with each test that fails.

@phil-davis phil-davis merged commit 6201f2d into cs3org:edge Jun 7, 2022
@phil-davis phil-davis deleted the update-expected-to-fail-file-edge branch June 7, 2022 03:56
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SwikritiT @phil-davis