Shares improvements #2674
Merged
Shares improvements #2674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
requested review from
a team,
labkode,
ishank011 and
glpatcern
as code owners
C0rby
force-pushed
the
shares-improvements
branch
from
a11a492
to
e584344
Compare
C0rby
force-pushed
the
shares-improvements
branch
from
e584344
to
bcfb451
Compare
C0rby
force-pushed
the
shares-improvements
branch
from
4941cd0
to
d9cac11
Compare
C0rby
force-pushed
the
shares-improvements
branch
from
d9cac11
to
4671a81
Compare
kobergj
approved these changes
Mar 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are shared resources in a space then all members are allowed to see those shares.
The json share manager was enhanced to check if the user is allowed to see a share by checking the grants on a resource.
I also cleaned up the code in the json share manager and reduced the runtime complexity of
ListReceivedShares.The new grants check actually needs to be added to the CS3 share manager too, I need to talk to @aduffeck though because I don't know if I somehow can get all shares.