-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grant id in mountpoint #2664
Merged
Merged
Grant id in mountpoint #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
micbar
force-pushed
the
grantID-in-mountpoint
branch
from
March 22, 2022 16:19
086a412
to
a4afb99
Compare
micbar
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
March 22, 2022 16:20
micbar
force-pushed
the
grantID-in-mountpoint
branch
from
March 22, 2022 16:34
a4afb99
to
ca08779
Compare
kobergj
requested changes
Mar 22, 2022
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
micbar
force-pushed
the
grantID-in-mountpoint
branch
from
March 22, 2022 19:34
ca08779
to
002fca5
Compare
kobergj
approved these changes
Mar 23, 2022
kobergj
approved these changes
Mar 23, 2022
C0rby
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small thing. Apart from that it looks fine.
micbar
force-pushed
the
grantID-in-mountpoint
branch
from
March 25, 2022 15:23
49d6b79
to
12eabed
Compare
micbar
force-pushed
the
grantID-in-mountpoint
branch
from
March 25, 2022 15:31
12eabed
to
def6a74
Compare
22 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We distinguish between an mountpoint and grants for shares.