implement if-match check in storageprovider #2547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C0rby
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
2 tasks
kobergj
reviewed
Feb 21, 2022
|
|
||
| switch sRes.Status.Code { | ||
| case rpc.Code_CODE_OK: | ||
| if sRes.Info.Etag != req.GetIfMatch() { |
There was a problem hiding this comment.
Any reason why we are calling req.GetIfMatch() again instead of using ifMatch variable?
C0rby
force-pushed
the
storage-if-match
branch
from
d72dd73
to
54c706a
Compare
kobergj
approved these changes
Feb 21, 2022
C0rby
force-pushed
the
storage-if-match
branch
from
54c706a
to
e25b9b3
Compare
butonic
approved these changes
Feb 22, 2022
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a check for the if-match value in InitiateFileUpload to prevent overwrites of newer versions.
Implements this feature: owncloud/ocis#3174