allow listing all storage spaces #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
spaces-registry-allow-list-all
branch
from
4e100c4
to
a2d55c7
Compare
butonic
requested review from
glpatcern,
ishank011,
labkode and
a team
as code owners
butonic
force-pushed
the
spaces-registry-allow-list-all
branch
from
1266085
to
4f354c2
Compare
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
spaces-registry-allow-list-all
branch
from
4f354c2
to
f30ae65
Compare
kobergj
approved these changes
Dec 9, 2021
22 tasks
26 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement the drives api we now listing all spaces when no filter is given. The Provider info will not contain any spaces as the client is responsible for looking up the spaces.
@aduffeck @kobergj @C0rby this really starts getting ugly because it starts to tap into the permission system. I'd like to discuss how to proceed.