Fix ocmd tutorial #2285
Fix ocmd tutorial #2285
Conversation
|
@butonic this may not be the desired fix - maybe it's better to leave users.demo.json as you changed it (including the 'https://') and then edit to providers.demo.json to match it? |
| @@ -87,6 +87,8 @@ driver = "json" | |||
| users = "users.demo.json" | |||
|
|
|||
| [http] | |||
| enabled_services = ["ocmd"] | |||
There was a problem hiding this comment.
Hm ok, I was under the impression that the ocmd service gets picked up by just having [http.services.ocmd] in the config...
Same for the providerauthorizer Middleware.
| @@ -2,7 +2,7 @@ | |||
| { | |||
| "id": { | |||
| "opaque_id": "4c510ada-c86b-4815-8820-42cdf82c3d51", | |||
| "idp": "https://cernbox.cern.ch", | |||
| "idp": "cernbox.cern.ch", | |||
There was a problem hiding this comment.
The id really should be a url. It may be compared to the oidc provider, which always is a url. Including the protocol.
There was a problem hiding this comment.
By 'id' you mean the "idp" field in a UserId object? I agree that the cs3apis documentation is undecisive and seems to tend towards making it a URL, but reva's current providerauthorizer interceptor code clearly requires it to be a domain.
I'll propose a non-breaking change in the providerauthorizer code so that it strips the protocol (if present) from the user's idp string before comparing it to the provider's domain string.
I'll also create a PR on the c3apis repo to make this clearer.
As discussed in cs3org/reva#2285
|
Closing this, let's discuss the desired string format in cs3org/cs3apis#159 and then we can adapt the code to that decision. |
Reverts part of @butonic's commit here
Reverts part of @butonic's commit here
Fixes #2284