Clarify UserId idp should be an origin #159
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in cs3org/reva#2285
This was referenced Nov 17, 2021
refs
approved these changes
Nov 26, 2021
wkloucek
reviewed
Dec 10, 2021
| @@ -33,7 +33,7 @@ import "cs3/types/v1beta1/types.proto"; | |||
| // A UserId represents a user. | |||
| message UserId { | |||
| // REQUIRED. | |||
| // The identity provider for the user. | |||
| // The origin (url without path) of the identity provider for the user, e.g. "https://example.com" or "http://localhost:8080" | |||
There was a problem hiding this comment.
how about IDPs supporting multiple realms like eg. Keycloak? (see also https://www.keycloak.org/docs/latest/server_admin/#core-concepts-and-terms)
Example:
https://keycloak.owncloud.test/auth/realms/oCIS-realm-1/protocol/openid-connect/...
https://keycloak.owncloud.test/auth/realms/oCIS-realm-2/protocol/openid-connect/...
The realms oCIS-realm-1 and oCIS-realm-2 behave like totally separate IDPs.
Maybe both of them have a user "albert", should they both be treated as the same user in REVA?
I don't think so. Therefore we would need to keep the full URL with path.
|
closing, see @wkloucek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in cs3org/reva#2285