Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace NoFork Terminology with TerraformPluginSDK #338

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Replace NoFork Terminology with TerraformPluginSDK #338

merged 5 commits into from
Feb 1, 2024

Commits on Feb 1, 2024

  1. Rename nofork related files so that nofork is replaced with tfpluginsdk 

    - pkg/controller/nofork_store.go is common to both the TF plugin SDK & framework
  so its name is preserved.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    547a439 View commit details
    Browse the repository at this point in the history

  2. Rename types with a "NoFork" in their names by replacing it with "Ter… 

    …raformPluginSDK"

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    70058d8 View commit details
    Browse the repository at this point in the history

  3. Add a more explanatory error message when immutable fields of a manag… 

    …ed resource have changed

- We currentl do not generate CRD validation rules for immutable fields and thus, if they
  are updated, we block it at the Terraform layer. The improve the error message for
  such cases as follows:
  "refuse to update the external resource because the following update requires replacing it"

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    6568a88 View commit details
    Browse the repository at this point in the history

  4. Fix nofork tests: Prevent using a global state in the Terraform plugi… 

    …n SDK v2 & framework tests

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d717974 View commit details
    Browse the repository at this point in the history

  5. Use controller.OperationTrackerFinalizer for both of the Terraform pl… 

    …ugin SDK &

framework based managed resources.

Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
    @ulucinar
    ulucinar committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    ca6672d View commit details
    Browse the repository at this point in the history