Replace NoFork Terminology with TerraformPluginSDK #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pkg/controller/nofork_store.go is common to both the TF plugin SDK & framework so its name is preserved. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
…raformPluginSDK" Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
…ed resource have changed - We currentl do not generate CRD validation rules for immutable fields and thus, if they are updated, we block it at the Terraform layer. The improve the error message for such cases as follows: "refuse to update the external resource because the following update requires replacing it" Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
…n SDK v2 & framework tests Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
added a commit
to ulucinar/upbound-provider-aws
that referenced
this pull request
Feb 1, 2024
- Please see: crossplane/upjet#338 for further details. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
1 task
ulucinar
force-pushed
the
rename-to-pluginsdk
branch
from
b555a9e
to
6c26c90
Compare
…ugin SDK & framework based managed resources. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
rename-to-pluginsdk
branch
from
6c26c90
to
ca6672d
Compare
ulucinar
added a commit
to ulucinar/upbound-provider-aws
that referenced
this pull request
Feb 1, 2024
- Please see: crossplane/upjet#338 for further details. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The nofork architecture now has the native implementations for both the Terraform plugin SDK v2 resources and the Terraform plugin framework resources. The repo uses
NoForkin the file & type names related to the plugin SDK v2 implementation. This PR aims to replace that terminology with theTerraformPluginSDKnaming.This PR also adds a more explanatory error message when immutable fields of a managed resource have changed. We currently do not generate CRD validation rules for immutable fields and thus, if they are updated, we block it at the Terraform layer. The improve the error message for such cases as follows:
refuse to update the external resource because the following update requires replacing itThis PR also fixes a race condition on a global state in the Terraform plugin SDK v2 & Terraform plugin framework based external client tests. The global state is a
fake.Terraformedobject, which is shared between multiple test cases. The theory is that changing the names of the test modules caused a reordering of the test executions, which revealed the race. Resolved by not sharing this state between test cases.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Tested via crossplane-contrib/provider-upjet-aws#1121.