fix: return correct types in wasm tests and add expected err #5883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal,
charleenfei,
chatton,
DimitrisJim,
srdtrk and
crodriguezvega
as code owners
chatton
approved these changes
Feb 21, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
Co-authored-by: Cian Hatton cian@interchain.io (cherry picked from commit 6b11895) # Conflicts: # modules/light-clients/08-wasm/types/querier_test.go
crodriguezvega
added a commit
that referenced
this pull request
Feb 23, 2024
…#5883) (#5887) * fix: return correct types in wasm tests and add expected err (#5883) Co-authored-by: Cian Hatton cian@interchain.io (cherry picked from commit 6b11895) # Conflicts: # modules/light-clients/08-wasm/types/querier_test.go * fix conflicts * remove duplicate code * remove duplicate code * fix test * fix: address test failures --------- Co-authored-by: Damian Nolan <damiannolan@gmail.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up from wasm testing fix for more fixes.
Co-authored-by: Cian Hatton cian@interchain.io
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.