Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/cosmos/cosmos-sdk from 0.50.3 to 0.50.4 #5872

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 20, 2024

Bumps github.com/cosmos/cosmos-sdk from 0.50.3 to 0.50.4.

Release notes

Sourced from github.com/cosmos/cosmos-sdk's releases.

v0.50.4

Cosmos SDK v0.50.4 Release Notes

💬 Release Discussion

🚀 Highlights

Some months ago Cosmos SDK Eden was released. Missed the announcement? Read it here. For this month patch release of the v0.50.x line, a few features and improvements were added to the SDK.

Notably, we added and fixed the following:

  • Adds in-place testnet CLI command for creating testnets from local state (kudos to @​czarcas7ic)
  • Multiple fixes in baseapp, with fixes in DefaultProposalHandler and vote extensions
  • Add a missed check in x/auth/vesting: GHSA-4j93-fm92-rp4m

We recommended to upgrade to this patch release as soon as possible.
When upgrading from <= v0.50.3, please ensure that 2/3 of the validator power upgrade to v0.50.4.

📝 Changelog

Check out the changelog for an exhaustive list of changes, or compare changes from the last release.

Refer to the upgrading guide when migrating from v0.47.x to v0.50.1. Note, that the next SDK release, v0.51.0, will not include x/params migration, when migrating from < v0.47, v0.50.x or v0.47.x, is a mandatory migration.

Changelog

Sourced from github.com/cosmos/cosmos-sdk's changelog.

v0.50.4 - 2023-02-19

Features

  • (server) #19280 Adds in-place testnet CLI command.

Improvements

  • (client) #19393 Add ReadDefaultValuesFromDefaultClientConfig to populate the default values from the default client config in client.Context without creating a app folder.

Bug Fixes

  • (x/auth/vesting) GHSA-4j93-fm92-rp4m Add BlockedAddr check in CreatePeriodicVestingAccount.
  • (baseapp) #19338 Set HeaderInfo in context when calling setState.
  • (baseapp): #19200 Ensure that sdk side ve math matches cometbft.
  • #19106 Allow empty public keys when setting signatures. Public keys aren't needed for every transaction.
  • (baseapp) #19198 Remove usage of pointers in logs in all optimistic execution goroutines.
  • (baseapp) #19177 Fix baseapp DefaultProposalHandler same-sender non-sequential sequence.
  • (crypto) #19371 Avoid CLI redundant log in stdout, log to stderr instead.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.50.3 to 0.50.4.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/v0.50.4/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@v0.50.3...v0.50.4)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from srdtrk as a code owner February 20, 2024 14:28
@DimitrisJim
Copy link
Contributor

getting a stack overflow in wasm tests but can't repro locally so far https://github.com/cosmos/ibc-go/actions/runs/7975079377/job/21772420213?pr=5872#step:4:416

lets keep this on hold for a sec

@damiannolan damiannolan changed the title build(deps): Bump github.com/cosmos/cosmos-sdk from 0.50.3 to 0.50.4 in /e2e build(deps): Bump github.com/cosmos/cosmos-sdk from 0.50.3 to 0.50.4 Feb 20, 2024
@crodriguezvega
Copy link
Contributor

getting a stack overflow in wasm tests but can't repro locally so far https://github.com/cosmos/ibc-go/actions/runs/7975079377/job/21772420213?pr=5872#step:4:416

I was able to reproduce locally.

@damiannolan
Copy link
Member

It's a recursive loop introduced by my PR this morning: #5870

Adding the Status call within VerifyMembership introduces a cyclic call because we use Status as the method invocation for registering mockVm callback in the 08-wasm test. Thus, we use clientState.Status() in the test and on that we make a querier call out to VerifyMembership - but, VerifyMembership's rpc handler now calls Status once again, introducing the recursive loop

I will comment out the test in this PR and push another fix to main to extract out this test or refactor it to not run into this

@damiannolan
Copy link
Member

Side note, could we make wasm tests required to pass when they are run?

@DimitrisJim
Copy link
Contributor

Side note, could we make wasm tests required to pass when they are run?

yea! Feel free to do in your PR for tweaking the test if you want.

@crodriguezvega
Copy link
Contributor

It's a recursive loop introduced by my PR this morning: #5870

♾️

@damiannolan
Copy link
Member

#5878 there's a fix here.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with rebasing after #5878, dropping approval for time being

@damiannolan
Copy link
Member

damiannolan commented Feb 21, 2024

wait for #5883 for all CI to pass I think

edit: I can revert the commented out test code and fix it up when ready

@damiannolan damiannolan enabled auto-merge (squash) February 21, 2024 22:19
@damiannolan damiannolan merged commit 046539a into main Feb 21, 2024
82 of 83 checks passed
@damiannolan damiannolan deleted the dependabot/go_modules/e2e/github.com/cosmos/cosmos-sdk-0.50.4 branch February 21, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Issues or PRs to update a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants