refactor(api)!: use cometbft's MockPV. #5709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
damiannolan,
charleenfei,
chatton,
srdtrk and
crodriguezvega
as code owners
DimitrisJim
commented
Jan 24, 2024
| @@ -520,9 +518,9 @@ func (s *ClientTestSuite) extractChainPrivateKeys(ctx context.Context, chain ibc | |||
| }) | |||
|
|
|||
| for _, filePV := range filePvs { | |||
| pvs = append(pvs, &ibcmock.PV{ | |||
| PrivKey: &ed25519.PrivKey{Key: filePV.PrivKey.Bytes()}, | |||
There was a problem hiding this comment.
seems this was initially done since a ed25519.PrivKey type exists in both sdk and comet and had to initialize by directly grabbing the bytes.
colin-axner
approved these changes
Jan 24, 2024
|
|
||
| // MockPV implements PrivValidator without any safety or persistence. | ||
| // Only use it for testing. | ||
| type PV struct { |
There was a problem hiding this comment.
We should document in the migration notes the removal of this type, right?
There was a problem hiding this comment.
definitely should! do you want to push it real quick? If not, can do in 5'.
crodriguezvega
changed the title
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #4015
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.