Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cometbft MockPV instead of reimplemting our own #4015

Closed
3 tasks
colin-axner opened this issue Jul 5, 2023 · 0 comments · Fixed by #5709
Closed
3 tasks

Use cometbft MockPV instead of reimplemting our own #4015

colin-axner opened this issue Jul 5, 2023 · 0 comments · Fixed by #5709
Assignees
@DimitrisJim
Labels
testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
Testing package i...

Comments

@colin-axner
Copy link
Contributor

Summary

If possible we should use cmttypes.MockPV instead of our own custom type

We used to rely on this type, but during one of the tendermint updates it was made private. It seems like it is public again, and I think it makes sense to use. Otherwise we are just duplicating that code anyways

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@colin-axner colin-axner added testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. labels Jul 5, 2023
@colin-axner colin-axner mentioned this issue Sep 4, 2023
Merged
9 tasks
@DimitrisJim DimitrisJim self-assigned this Jan 16, 2024
@DimitrisJim DimitrisJim mentioned this issue Jan 24, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DimitrisJim DimitrisJim

Labels
testing Testing package and unit/integration tests type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
ibc-go
Archived in project
Milestone
Testing package improvements
Development

Successfully merging a pull request may close this issue.

refactor(api)!: use cometbft's MockPV. cosmos/ibc-go
2 participants
@DimitrisJim @colin-axner